Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo unittest docs #97742

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

annonm
Copy link
Contributor

@annonm annonm commented Oct 2, 2022

I noticed a small grammatical mistake that could be fixed.

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 2, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 2, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please sign the CLA :)

@annonm
Copy link
Contributor Author

annonm commented Oct 2, 2022

Looks good, but please sign the CLA :)

Got it - should be signed now, thanks!

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed awaiting merge labels Oct 3, 2022
@JelleZijlstra JelleZijlstra merged commit e6f9ec5 into python:main Oct 3, 2022
@miss-islington
Copy link
Contributor

Thanks @annonm for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 3, 2022
@bedevere-bot
Copy link

GH-97762 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2022
(cherry picked from commit e6f9ec5)

Co-authored-by: annonm <[email protected]>
@bedevere-bot
Copy link

GH-97763 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 3, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2022
(cherry picked from commit e6f9ec5)

Co-authored-by: annonm <[email protected]>
miss-islington added a commit that referenced this pull request Oct 3, 2022
(cherry picked from commit e6f9ec5)

Co-authored-by: annonm <[email protected]>
miss-islington added a commit that referenced this pull request Oct 3, 2022
(cherry picked from commit e6f9ec5)

Co-authored-by: annonm <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 3, 2022
* main: (2069 commits)
  pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)
  pythongh-94808: Coverage: Check picklablability of calliter (python#95923)
  pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)
  pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)
  Fix typos in `bltinmodule.c`. (pythonGH-97766)
  pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)
  pythongh-97681: Remove Tools/demo/ directory (python#97682)
  Fix typo in unittest docs (python#97742)
  pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)
  pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)
  pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)
  pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)
  pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)
  pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)
  pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)
  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)
  pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)
  pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)
  pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)
  pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)
  ...
@annonm annonm deleted the fix-typo-unittest-docs branch October 5, 2022 01:32
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
(cherry picked from commit e6f9ec5)

Co-authored-by: annonm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants